Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use endpoints and url_for() instead of hardcoding language prefixes #70

Closed
wanderingstan opened this issue Jan 31, 2018 · 1 comment · Fixed by #94
Closed

Use endpoints and url_for() instead of hardcoding language prefixes #70

wanderingstan opened this issue Jan 31, 2018 · 1 comment · Fixed by #94

Comments

@wanderingstan
Copy link
Contributor

Right now we have to manually construct URL's for any page that is lanuage aware. E.g.
https://www.originprotocol.com/ko/presale is generated here
https://github.com/OriginProtocol/company-website/blob/master/templates/navbar.html#L33
as

<a class="nav-link" href="{{'/%s/presale'% CURRENT_LANGUAGE}}">{{gettext("Presale")}}</a>

Much better to use endpoints and url_for().
https://stackoverflow.com/a/19262349/59913
@wanderingstan
Copy link
Contributor Author

@micahalcorn Can you look at this housecleaning, since you figured out the url_for() syntax for partners page?

@micahalcorn micahalcorn mentioned this issue Feb 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@wanderingstan