-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: new multiselectionstyle for features in active layer #1846
Conversation
New multiselectionstyle, inActiveLayer
Now it is good to test. Adds a new multiSelectionStyle, inActiveLayer that styles the features in the layer active in the infowindow. No need to change any config if you don't want to use this feature. Note: This is only useful when using the multiselection tool with the tabbed layout (listLayout: false that is)
|
Does not work for me. It was clever to use the first part of id to determine if the feature belongs to the active layer. Maybe too clever as not all layers have the layer name as a part of the id. For example the origo-cities geojson does not work. Also AGS layers probably won't work. Also I'm not sure how that id corresponds to the selection group name, especially when the layer name parameter does not equal the layer id (when using the id parameter). Probably some lookup mechanism is needed if the feature itself shall not carry information of which layer it belongs to, something that we want to avoid. Besides that you left a console.log and setting of property inAvctiveLayer in onItemAdded() which is probably never used. |
Right on. Hopefully this is fixed now |
LGTM. That was a clever fix. If I could approve stuff I would. As a side note: it is not only useful when using Multiselect as you wrote, it also works for ordinary featureInfo when infowindow is used. |
Fixes #1836
However since similar work will be done in #1773 I mark it as Draft.