Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide opacitySlider #1867

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix: hide opacitySlider #1867

merged 2 commits into from
Oct 20, 2023

Conversation

jokd
Copy link
Contributor

@jokd jokd commented Oct 20, 2023

Fixes #1861

@jokd jokd marked this pull request as ready for review October 20, 2023 10:44
@johnnyblasta
Copy link
Collaborator

I'm getting an error when looking at the layer info and opacitySlider turned off.
image

@jokd
Copy link
Contributor Author

jokd commented Oct 20, 2023

Sorry for not testing thoroughly but now there's hopefully no errors in the console.

johnnyblasta
johnnyblasta approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@johnnyblasta johnnyblasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, if everything was perfect at first it wouldn't be a need for others to test.

LGTM

@jokd jokd merged commit 833a16d into master Oct 20, 2023
4 checks passed
@jokd jokd deleted the hide-opacityslider branch October 20, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyblasta johnnyblasta johnnyblasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opacitySlider always rendered
2 participants
@jokd @johnnyblasta