Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate change the same as opening a new panel #34

Closed
joneslafuente opened this issue Dec 8, 2015 · 5 comments
Closed

Animate change the same as opening a new panel #34

joneslafuente opened this issue Dec 8, 2015 · 5 comments
Assignees
Labels

Comments

@joneslafuente
Copy link

A good option would be to animate the closing of the open panel before opening the new one. Is this possible to add myself or does it need an update? I am not a programmer. Also could the open panel be closed by clicking on the body of the page? Apart from these points, excellent code.

Thanks

@orion3dgames
Copy link
Owner

Hello. I've tried in the past with no success, as the movement of sliding up and down makes you feel sea sick... And when you click somewhere you expect an instant reaction, not having to wait .5s for the panel to slide down and then slide up. At the moment, It only slides up when you close the panel with close button.

@orion3dgames
Copy link
Owner

Adding an clickable overlay beneath the panel is a good idea, i'll look into it for the next version.

@joneslafuente
Copy link
Author

Thanks. Look forward to the update.

On Wed, Dec 9, 2015 at 6:55 AM, Orion Gunning notifications@github.com
wrote:

Adding an clickable overlay beneath the panel is a good idea, i'll look
into it for the next version.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@joneslafuente
Copy link
Author

I agree with the effect of sliding one closed and then another opening may
not be so great. Thanks.

On Wed, Dec 9, 2015 at 6:55 AM, Orion Gunning notifications@github.com
wrote:

Hello. I've tried in the past with no success, as the movement of sliding
up and down makes you feel sea sick... And when you click somewhere you
expect an instant reaction, not having to wait .5s for the panel to slide
down and slide up. It only slides up when you close the panel with close
button.


Reply to this email directly or view it on GitHub
#34 (comment)
.

@orion3dgames
Copy link
Owner

After reflexion, the overlay (modal style) does not seem like a good feature as it would cause unwanted closing, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants