Support local images with simple names #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.94% // Head: 85.87% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 85.94% 85.87% -0.08%
==========================================
Files 50 50
Lines 2348 2350 +2
==========================================
Hits 2018 2018
- Misses 172 173 +1
- Partials 158 159 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
orlangure
force-pushed
the
fix-local-simple-image
branch
from
d8058dd
to
3982461
Compare
Previously only full image names were supported (library/something or user/something), but often people want to run tests using local images that they have after running docker builds, like "sample-image".
orlangure
force-pushed
the
fix-local-simple-image
branch
from
3982461
to
aa90bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only full image names were supported (library/something or user/something), but often people want to run tests using local images that they have after running docker builds, like "sample-image".
Fixes #795