Fix is_overridden ignoring class attributes

orlnub123 · Mar 12, 2019 · a964c1c · a964c1c
1 parent 3959fd1
commit a964c1c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 ### Fixed
 
 - Fixed indented Settings subclasses erroring.
+- Fixed `Settings.is_overridden` ignoring class attributes.
 
 ## [0.1.1] - 2018-11-20
 

diff --git a/class_settings/settings.py b/class_settings/settings.py
@@ -87,4 +87,9 @@ def __getattr__(self, name):
         return getattr(default_settings, name)
 
     def is_overridden(self, setting):
-        return setting in vars(self)
+        try:
+            self.__getattribute__(setting)  # Avoids __getattr__
+        except AttributeError:
+            return False
+        else:
+            return True