Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: eslint-plugin-ornikar improve ignoreFiles in typescript-no-unused-exports [no issue] #633

Merged
merged 3 commits into from
Oct 23, 2023
Merged

feat: eslint-plugin-ornikar improve ignoreFiles in typescript-no-unused-exports [no issue] #633

merged 3 commits into from
Oct 23, 2023

Conversation

christophehurpeau
Copy link
Contributor

@christophehurpeau christophehurpeau commented Oct 20, 2023 •
edited
Loading

Context

improve ignore patterns to remove all issues in instructors-app

@christophehurpeau christophehurpeau requested a review from a team as a code owner October 20, 2023 13:49
@reviewflow
Copy link

reviewflow bot commented Oct 20, 2023 •
edited
Loading

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@christophehurpeau christophehurpeau changed the title feat: eslint-plugin-ornikar improve ignoreFiles in typescript-no-unused-exports feat: eslint-plugin-ornikar improve ignoreFiles in typescript-no-unused-exports [no issue] Oct 20, 2023
@reviewflow reviewflow bot added the 🔜 automerge Synced by reviewflow for merge/automerge label Oct 20, 2023
@reviewflow reviewflow bot enabled auto-merge (squash) October 20, 2023 14:03
vjarysta
vjarysta approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@vjarysta vjarysta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@reviewflow reviewflow bot merged commit db2c331 into main Oct 23, 2023
8 of 9 checks passed
@reviewflow reviewflow bot deleted the feat/eslint-plugin-ornikar-improve-ignoreFiles-in-typescript-no-unused-exports branch October 23, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjarysta vjarysta vjarysta approved these changes

Assignees

@christophehurpeau christophehurpeau

Labels
🔜 automerge Synced by reviewflow for merge/automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophehurpeau @vjarysta