Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-config-typescript): add @typescript-eslint/no-unnecessary-boolean-literal-compare [no issue] #669

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat(eslint-config-typescript): add @typescript-eslint/no-unnecessary-boolean-literal-compare [no issue] #669

merged 1 commit into from
Nov 15, 2023

Conversation

PSniezak
Copy link
Contributor

@PSniezak PSniezak self-assigned this Nov 15, 2023
@reviewflow reviewflow
Copy link

reviewflow bot commented Nov 15, 2023 •
edited
Loading

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@PSniezak PSniezak marked this pull request as ready for review November 15, 2023 10:30
@PSniezak PSniezak requested a review from a team as a code owner November 15, 2023 10:30
vjarysta
vjarysta approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@vjarysta vjarysta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@PSniezak PSniezak merged commit 89d8369 into main Nov 15, 2023
9 of 10 checks passed
@PSniezak PSniezak deleted the feat/eslint-config-typescript/implement-no-unnecessary-boolean-literal-compare-no-issue branch November 15, 2023 11:11
christophehurpeau
christophehurpeau reviewed Nov 15, 2023
View reviewed changes
@ornikar/eslint-config-typescript/tests/no-unnecessary-boolean-literal-compare.ts
/* eslint-disable no-empty */
/* Incorrect */

declare const someCondition: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export plutot que declare ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophehurpeau christophehurpeau christophehurpeau left review comments

@vjarysta vjarysta vjarysta approved these changes

Assignees

@PSniezak PSniezak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PSniezak @christophehurpeau @vjarysta