Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add prerelease job [no issue] #906

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

christophehurpeau
Copy link
Contributor

Context

Currently it is really painful to do releases in pull requests.
This simplifies the process with this hold job.

@christophehurpeau christophehurpeau requested a review from a team as a code owner May 2, 2023 15:44
@reviewflow
Copy link

reviewflow bot commented May 2, 2023

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@reviewflow
Copy link

reviewflow bot commented May 2, 2023

@christophehurpeau : Force-pushing after the review started is a bad practice. See https://ornikar.atlassian.net/wiki/spaces/TECH/pages/2972090451/Commits+and+Pull+Requests#Code-Review for more information.

@christophehurpeau christophehurpeau merged commit 65d7c0e into main May 4, 2023
@christophehurpeau christophehurpeau deleted the ci/add-prerelease-job branch May 4, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants