Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get relative path from extract translations file [no issue] #973

Merged

Conversation

charles-gourdin-ornikar
Copy link
Contributor

Context

The extract-translations file contains a filename check to avoid duplicates. The absolute path is checked. However, if this has a dot before the file extension, the check is not correct.

Solution

Use relative filename path instead.

@reviewflow
Copy link

reviewflow bot commented Sep 15, 2023

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
☑️ Step 3: 👌 Code Review
☑️ Step 4: 🚦 Merge Pull Request

Options:

  • 🔜 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@reviewflow reviewflow bot changed the title fix: get relative path from extract translations file [no-issue] fix: get relative path from extract translations file [no issue] Sep 15, 2023
Copy link
Contributor

@christophehurpeau christophehurpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci!

@charles-gourdin-ornikar charles-gourdin-ornikar merged commit 7547e46 into main Sep 15, 2023
8 of 9 checks passed
@charles-gourdin-ornikar charles-gourdin-ornikar deleted the fix/no-issue/extract-translation-path-error branch September 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants