Allowing Put/Get to receive Kokkos Views with HIP backend #3571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a bug, more of an oversight (we don't need this in the current release).
I tested the Kokkos backend in ADIOS2 with HIP on Crusher and it works fine as long as we pass the pointer (i.e.
view.data()
). I forgot to add the HIP memory space in the part of ADIOS2 that allows submitting directly theKokkos::View
. This PR fixes that.Tested on Crusher BP4/BP5.