Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around with include <unistd.h> on windows #3652

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

guj
Copy link
Contributor

@guj guj commented Jun 2, 2023

to fix the issue reported here:
#3649 (comment)

@guj guj requested a review from vicentebolea as a code owner June 2, 2023 21:06
source/h5vol/CMakeLists.txt Outdated Show resolved Hide resolved
@guj guj merged commit c6b1cca into ornladios:master Jun 5, 2023
@ax3l
Copy link
Contributor

ax3l commented Jun 5, 2023

@guj shouldn't this go into release_29?

@ax3l
Copy link
Contributor

ax3l commented Jun 30, 2023

@vicentebolea can you please backport this to release_29? :)

vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Jul 3, 2023
work around  with include <unistd.h> on  windows

(cherry picked from commit c6b1cca)
vicentebolea pushed a commit to vicentebolea/ADIOS2 that referenced this pull request Jul 3, 2023
work around  with include <unistd.h> on  windows

(cherry picked from commit c6b1cca)
vicentebolea added a commit that referenced this pull request Jul 4, 2023
* release_29:
  Merge pull request #3684 from eisenhauer/FixLeak
  Merge pull request #3652 from guj/unistd-windows
  Merge pull request #3650 from ornladios/dependabot/pip/docs/cryptography-41.0.0
  Merge pull request #3673 from vicentebolea/disable-ascent-install-test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants