Python API: Adios() new argument 'config_file', Stream() new argument… #3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnorbert
force-pushed
the
python-adios-stream-fixes
branch
2 times, most recently
from
33fa7b9
to
9791286
Compare
vicentebolea
reviewed
Jan 5, 2024
|
A rebase will fix the CI |
… 'io_name' that must go together with 'config_file' Gray-Scott example's python scripts fixed to use the new Stream() object
pnorbert
force-pushed
the
python-adios-stream-fixes
branch
from
4c3b723
to
165485b
Compare
Well, rebase with release_210 did not seem to fix the CI for this PR. Another PR based on master is now passing. |
There is a PR for release_210 that fixes this at #3992 |
|
I've done a rebase in the Github interface. Now that #3992 is merged, this should pass. |
eisenhauer
approved these changes
Jan 12, 2024
pnorbert
added a commit
to pnorbert/ADIOS2
that referenced
this pull request
Jan 12, 2024
ornladios#3984) * Python API: Adios() new argument 'config_file', Stream() new argument 'io_name' that must go together with 'config_file' Gray-Scott example's python scripts fixed to use the new Stream() object * Make 'comm' a named optional argument for Stream. --------- Co-authored-by: Greg Eisenhauer <eisen@cc.gatech.edu>
eisenhauer
added a commit
that referenced
this pull request
Jan 12, 2024
#3984) (#3999) * Python API: Adios() new argument 'config_file', Stream() new argument 'io_name' that must go together with 'config_file' Gray-Scott example's python scripts fixed to use the new Stream() object * Make 'comm' a named optional argument for Stream. --------- Co-authored-by: Greg Eisenhauer <eisen@cc.gatech.edu>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… 'io_name' that must go together with 'config_file'
Gray-Scott example's python scripts fixed to use the new Stream() object