Feature: Dictionaries (custom entities) and enum CRUD #338
Conversation
- allow to add/edit custom enums, dictionaries and custom entities that have non-integer primary key - add these entities to menu - add validation for all enum entities
- get modified form data after submit
|
Thank you for your pull request. It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/ If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits. Once you've signed the CLA, please allow for about an hour for the submission to be processed. |
| $groupConfigProvider = $this->configManager->getProvider('grouping'); | ||
|
|
||
| $withHidden = true; // TODO: move it to configuration | ||
| $extendConfigs = $entityExtendProvider->getConfigs(null, $withHidden); |
There was a problem hiding this comment.
you do not need provider here, you can get Configs from configManager instead , e.g.
$this->configManager->getConfigs('extend', null, true)
|
"This branch has conflicts that must be resolved" |
| * @return bool | ||
| */ | ||
| protected function isEnumClass($entityClass) | ||
| { |
There was a problem hiding this comment.
Please change to verification by enum code - for enums it should be present in config, e.g. run console command
./app/console oro:entity-config:debug "Extend\Entity\EV_Lead_Source"
in output you'll see something like
[enum] => Array
(
[code] => lead_source
[public] =>
[multiple] =>
)
|
@ishakuta Thanks for your contribution, i think it will be a nice feature. |
|
@ishakuta hi and tanks for you contribution! Would you be so kind and tell us, are you still interested to finish this PR? |
|
@iklymenko yes I'm interested, I'll try to update it ASAP |
|
Hi @ishakuta Enum editing via UI was implemented in system by oro team. This PR is still actual ? |
|
no, it's not, thank you |
It's possible to edit enums out of the box from entity management UI, but if it's not allowed for some user, this approach could be helpful: