Run diagnostics on live AudioContext #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orottier
commented
Nov 24, 2023
| @@ -344,6 +344,26 @@ impl AudioContext { | |||
| self.base().clear_event_handler(EventType::SinkChange); | |||
| } | |||
|
|
|||
| #[allow(clippy::missing_panics_doc)] | |||
| pub fn run_diagnostics<F: Fn(String) + Send + 'static>(&self, callback: F) { | |||
There was a problem hiding this comment.
Wondering if we should mark this method #[doc(hidden)] because I could imagine we are not keeping the API stable over different versions. Would be interesting to return more structured data in the future
orottier
commented
Nov 24, 2023
src/context/online.rs
Outdated
| EventHandler::Once(Box::new(callback)), | ||
| ); | ||
|
|
||
| let buffer = Vec::with_capacity(32 * 1024); |
There was a problem hiding this comment.
32kB ought to be enough for anybody.
-- Bill Gates
|
/bench because we are messing with vtables here in tight loops |
orottier
commented
Nov 24, 2023
|
|
||
| /// Return the name of the actual AudioProcessor type | ||
| #[doc(hidden)] // not meant to be user facing | ||
| fn name(&self) -> &'static str { |
There was a problem hiding this comment.
This method enables us to ask a Box<dyn AudioProcessor> what its true type is (e.g. ConstantSourceRenderer). This opens the way to mute audio graph legs with no side effects like proposed in #397
There was a problem hiding this comment.
Nice, I'll try to make to list all the cases I can think of about this graph thing next week
|
|
Looks all good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
context.run_diagnostics(|s| println!("Diagnostics:\n{}", s));It will generate a report on the next render quantum, in a somewhat realtime safe manner.
This will hopefully aid debugging of e.g. #396