OfflineAudioContext event handlers #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was not emitted because the OfflineAudioContext has no event loop running. By overriding the trait we do make this happen. TODO: if you call offline_context.base().set_onstatechange we run the wrong handler code stil..
It is not necessary to expose it because the BaseAudioContext methods are available on the object itself, plus it causes issues for the `set_onstatechange` handler, see b0b03a6
12 tasks
b-ma
reviewed
Feb 23, 2024
| @@ -21,6 +21,7 @@ use crate::{node, AudioListener}; | |||
| #[allow(clippy::module_name_repetitions)] | |||
| pub trait BaseAudioContext { | |||
| /// Returns the [`BaseAudioContext`] concrete type associated with this `AudioContext` | |||
| #[doc(hidden)] // we'd rather not expose the ConcreteBaseAudioContext | |||
There was a problem hiding this comment.
I believe a pub trait must have all items pub. Will check later
There was a problem hiding this comment.
Oh right, didn't realise it was a trait
b-ma
approved these changes
Feb 23, 2024
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411