You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if making the main structs (de)serializable using #[derive(Deserializable, Serializable)] from serde wouldn't be a good addition. I'm new to rust so maybe there is a way to do this easily from outside the crate, so this starts more as a question than a suggestion. I tried to use serde's remote serialization but, besides having to mirror all structs from this library, I bumped into Vec<OpengraphObejct> and I couldn't find a way easily (in a declarative way) define how to (de)serialize that.
I know adding serde as a dependency might not be desired by all users, but maybe it can be added conditionally through a feature flag?
If you think this is a good idea I might even give it a try as a rust exercise :)
PS: Unrelated quick question: any reason why Webpage doesn't derive Debug too? I notice most structs in the library do.
The text was updated successfully, but these errors were encountered:
I wonder if making the main structs (de)serializable using
#[derive(Deserializable, Serializable)]
from serde wouldn't be a good addition. I'm new to rust so maybe there is a way to do this easily from outside the crate, so this starts more as a question than a suggestion. I tried to use serde's remote serialization but, besides having to mirror all structs from this library, I bumped intoVec<OpengraphObejct>
and I couldn't find a way easily (in a declarative way) define how to (de)serialize that.I know adding serde as a dependency might not be desired by all users, but maybe it can be added conditionally through a feature flag?
If you think this is a good idea I might even give it a try as a rust exercise :)
PS: Unrelated quick question: any reason why
Webpage
doesn't deriveDebug
too? I notice most structs in the library do.The text was updated successfully, but these errors were encountered: