Add optional serialization using serde #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the tests in schema_org.rs are using an old API that used an Option as the return for SchemaOrg::from().
While filling up html.text_content in the parser, a leading space is added unconditionally to separate multiple segments, but for the first segment the space should be avoided.
When including the new features = ["serde"] in the dependency specification, all structs provided by the library become (de)serializable using serde.
Closed
|
I just amended the last commit with some fixes. Now I tested it creating a simple test crate consisting of: fn main() {
let web = webpage::Webpage::from_url(
"http://www.rust-lang.org/en-US/",
webpage::WebpageOptions::default(),
)
.unwrap();
println!("{}", serde_json::to_string(&web).unwrap());
}And [dependencies]
webpage = { path = "../webpage-rs", features = ["serde"] }
serde_json = "1.0"To run the tests with the feature enabled, I had to use |
|
Thanks, also for the additional fixes! |
|
Thanks for meeting it in so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #4 by making all structs serializable using serde when the new
serdefeature is used in the dependency declaration.It also adds
derive(Debug)toWebpageandWebpageOptions(as they were missing) and fixes some tests and a small bug.