Update ExpressionCompiler to run on JDK17+ without 'add-opens' JVM opt using Javassist ClassPool.toClass overload that takes a neighbour class #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method to instantiate a CtClass to a Class. The newly introduced method invokes ClassPool.toClass(CtClass, Class neighbour). The introduction of this method allows subclassers of ExpressionCompiler to customise the exact mechanics of the class instantiation process if needed.
|
After merging this change a lot of tests fail - it works good on JDK17. I'm going to revert this PR and introduce this change once OGNL will switch to JDK17 |
|
You can always use |
lukaszlenart
added a commit
that referenced
this pull request
Jul 24, 2023
lukaszlenart
added a commit
that referenced
this pull request
Jul 24, 2023
Partially reverts #214 to keep compatibility with JDK8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #160 by pointing Javassist at a neighbour (a class in the same package) class of the class we're generating, allowing it to avoid using the deprecated
ClassLoader.defineClass(which now requires 'add-opens' to use because Javassist must use reflection to make the method visible), and instead useMethodHandles.This implementation introduces a protected method
instantiateClassthat can be overridden byExpressionCompilersubclassers who are customising the exact mechanics of the class instantiation process if needed.