Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intelligently load spice kernels #23

Closed
1 of 4 tasks
ortk95 opened this issue Oct 28, 2022 · 1 comment
Closed
1 of 4 tasks

Intelligently load spice kernels #23

ortk95 opened this issue Oct 28, 2022 · 1 comment
Labels
backend Related to the backend (coordinate conversion, SPICE etc.) bug Something isn't working enhancement New feature or request
Milestone

Comments

@ortk95
Copy link
Owner

ortk95 commented Oct 28, 2022

Currently we load the same set of spice kernels every single time a Body is initialised - this has a number of issues:

  1. Loading kernels isn't instantaneous (~0.3s)
  2. Creating a large number of bodies in the same session causes a SpiceNOMOREROOM error
  3. Re-loading the same kernels is generally inefficient and messy

Possible fixes:

  • Dynamically check if desired kernels are already loaded
  • Add some flag somewhere to indicate kernels are already loaded
    • This could potentially cause issues if the user unloads kernels, so would need to document this somewhere
  • Add separate function to load the kernels somewhere
@ortk95 ortk95 added bug Something isn't working enhancement New feature or request labels Oct 28, 2022
ortk95 added a commit that referenced this issue Nov 1, 2022
Possibly helpful for #23
@ortk95
Copy link
Owner Author

ortk95 commented Nov 1, 2022

Added flag in ac09b2b - this is probably an improvement, but may cause issues if user manually loads/unloads kernels

@ortk95 ortk95 added the backend Related to the backend (coordinate conversion, SPICE etc.) label Nov 1, 2022
@ortk95 ortk95 added this to the v1.0 milestone Nov 11, 2022
@ortk95 ortk95 closed this as completed Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the backend (coordinate conversion, SPICE etc.) bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant