Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: input components #612

Merged
merged 26 commits into from
Oct 7, 2023
Merged

Conversation

mlmoravek
Copy link
Member

Based on the update-config PR #605

This is part of #606

In this pull request I refactored all on OInput based components from Options-API to Composition-API.
Also some improvements are made and bugs are fixed.

Fixes #513
Fixes #570
Fixes #530
Fixes #516
Fixes #515

Proposed Changes

@mlmoravek mlmoravek added bug Something isn't working breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit a133a65
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652156d3d515250007e770ee
😎 Deploy Preview https://deploy-preview-612--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek changed the title refactor: input components #2 refactor: input components Oct 6, 2023
@mlmoravek mlmoravek self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 282 lines in your changes are missing coverage. Please review.

Comparison is base (e7bdb07) 62.32% compared to head (a133a65) 63.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #612      +/-   ##
===========================================
+ Coverage    62.32%   63.94%   +1.62%     
===========================================
  Files           79       87       +8     
  Lines         5622     5606      -16     
  Branches      1575     1587      +12     
===========================================
+ Hits          3504     3585      +81     
+ Misses        2007     1910      -97     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 55.65% <58.89%> (+8.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/oruga-next/src/composables/useClassProps.ts 100.00% <100.00%> (ø)
packages/oruga-next/src/composables/useDebounce.ts 100.00% <100.00%> (ø)
...ackages/oruga-next/src/composables/usePropValue.ts 100.00% <100.00%> (ø)
packages/oruga-next/src/utils/SharedProps.ts 100.00% <100.00%> (ø)
packages/oruga-next/src/utils/helpers.ts 9.92% <ø> (+1.44%) ⬆️
packages/oruga-next/src/utils/ssr.ts 100.00% <ø> (ø)
...ges/oruga-next/src/composables/useEventListener.ts 75.00% <75.00%> (ø)
...ckages/oruga-next/src/composables/useMatchMedia.ts 81.81% <81.81%> (ø)
packages/oruga-next/src/components/field/Field.vue 80.00% <81.66%> (+20.62%) ⬆️
...s/oruga-next/src/components/field/useFieldShare.ts 54.16% <54.16%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	packages/docs-next/.vitepress/theme/index.ts
#	packages/docs-next/components/Modal.md
#	packages/docs-next/components/Notification.md
#	packages/oruga-next/src/types/config.ts
@mlmoravek mlmoravek merged commit b35c339 into oruga-ui:develop Oct 7, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-inputs branch October 7, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment