Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: notification component #620

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Oct 8, 2023

This is part of #606

In this PR I refactored the notification component from Options-API to Composition-API.

Proposed Changes

  • Updated Notification to composition api
  • Updated Notification programmatic usage
  • Remove unused mixin
  • Docs: add sub componenten description

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 8, 2023
@mlmoravek mlmoravek self-assigned this Oct 8, 2023
@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 4aae4fd
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6522fc7b913f2100088027b9
😎 Deploy Preview https://deploy-preview-620--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b056187) 63.86% compared to head (4aae4fd) 63.84%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #620      +/-   ##
===========================================
- Coverage    63.86%   63.84%   -0.02%     
===========================================
  Files           87       87              
  Lines         5606     5606              
  Branches      1587     1587              
===========================================
- Hits          3580     3579       -1     
- Misses        1915     1916       +1     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 55.10% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 6da9426 into oruga-ui:develop Oct 9, 2023
10 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-notification branch October 9, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant