Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sidebar): update api #626

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

mlmoravek
Copy link
Member

This is part of #606

In this PR, I refactored the sidebar component from the Options API to the Composition API.
I also make the sidebar programmatically.

Proposed Changes

  • Update Sidebar to composition api
    • change prop open to active
  • Update docs
  • Add sidebar programmtic usage
  • Adjust Modal component
  • Fix useProgrammatic

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 15, 2023
@mlmoravek mlmoravek self-assigned this Oct 15, 2023
@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit bb56700
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652bce9b3c172c0008bfd7d5
😎 Deploy Preview https://deploy-preview-626--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fd7f324) 62.86% compared to head (bb56700) 62.74%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #626      +/-   ##
===========================================
- Coverage    62.86%   62.74%   -0.12%     
===========================================
  Files           87       87              
  Lines         5587     5589       +2     
  Branches      1590     1590              
===========================================
- Hits          3512     3507       -5     
- Misses        1964     1971       +7     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 49.19% <0.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/oruga-next/src/composables/useProgrammatic.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 49c0248 into oruga-ui:develop Oct 16, 2023
8 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-sidebar branch October 16, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant