Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(table): update api #639

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Oct 22, 2023

This is part of #606

In this pull request I refactored the table component from Options-API to Composition-API.
Also some improvements are made and bugs are fixed.

Fixes #591
Fixes #508

Proposed Changes

@mlmoravek mlmoravek added bug Something isn't working breaking Breaking changes refactoring This involves some refactoring of existing code. labels Oct 22, 2023
@mlmoravek mlmoravek self-assigned this Oct 22, 2023
@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 824ead6
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/653786c250e64d0008df1ea0
😎 Deploy Preview https://deploy-preview-639--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (67e93a2) 59.04% compared to head (824ead6) 59.07%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
+ Coverage    59.04%   59.07%   +0.03%     
===========================================
  Files           87       87              
  Lines         2415     2429      +14     
  Branches       809      814       +5     
===========================================
+ Hits          1426     1435       +9     
- Misses         878      883       +5     
  Partials       111      111              
Flag Coverage Δ
oruga 67.21% <ø> (ø)
oruga-next 48.98% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/oruga-next/src/composables/useParentProvider.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit bf7713d into oruga-ui:develop Oct 24, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the update-table branch October 24, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes bug Something isn't working refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table check all slot OTable: Access to native PointerEvent in @click handlers
1 participant