Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tabs): update api #642

Merged
merged 13 commits into from
Oct 25, 2023
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Oct 24, 2023

This is part of #606

In this pull request I refactored the tabs component from Options-API to Composition-API.
Also some improvements are made and bugs are fixed.

Proposed Changes

  • Update Tabs to composition api
  • Update docs
  • Add new change event

@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Oct 24, 2023
@mlmoravek mlmoravek self-assigned this Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 2e932fc
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6537dc1b855cf90008208f80
😎 Deploy Preview https://deploy-preview-642--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek changed the title Refactor tabs refactor(tabs): update api Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (093e2b9) 67.21% compared to head (2e932fc) 59.07%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #642      +/-   ##
===========================================
- Coverage    67.21%   59.07%   -8.14%     
===========================================
  Files           64       87      +23     
  Lines         1345     2429    +1084     
  Branches       403      814     +411     
===========================================
+ Hits           904     1435     +531     
- Misses         330      883     +553     
  Partials       111      111              
Flag Coverage Δ
oruga 67.21% <ø> (ø)
oruga-next 48.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 267313a into oruga-ui:develop Oct 25, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-tabs branch October 25, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant