Add wrapper library for HTTP Managers #130
Conversation
|
How about moving the package to |
|
Could you please add unit tests and sign the DCO using |
|
Oh and a note in the docs would be great! Maybe in the FAQ section? :) |
|
Can't build now, I'm getting this: |
Signed-off-by: Mohamedh Fazal <mohamedhfazal@gmail.com>
|
make sure to update your local dependencies or use glide, fosite got updated last night |
Signed-off-by: Mohamedh Fazal <mohamedhfazal@gmail.com>
Signed-off-by: Mohamedh Fazal <mohamedhfazal@gmail.com>
| ``` | ||
| 2. Use the API | ||
|
|
||
| **OAuth Clients**: `client.Client` |
There was a problem hiding this comment.
Maybe add examples here? e.g.
// client, err := ...
oauth2Client, err := client.Client.GetClient("1234")
|
When you said unit tests, did you mean something similar to tests in HTTP Managers or did you have something else in mind? |
|
You don't need to test the embedded structs (e.g. |
Signed-off-by: Mohamedh Fazal <mohamedhfazal@gmail.com>
|
I forget to sign every other commit and it looks messy. Sorry about that, is that okay?. Shall I create a new PR? |
Signed-off-by: Mohamedh Fazal <mohamedhfazal@gmail.com>
| } | ||
|
|
||
| // SkipSSL skips TLS verification | ||
| func SkipSSL() option { |
There was a problem hiding this comment.
Could you rename this to SkipTLSVerify, it's clearer then that the tls verification is disabled, not SSL in total
|
no that's fine, you don't need to sign every commit. I will squash them anyways :) thanks for your hard work! |
Signed-off-by: Mohamedh Fazal <mohamedhfazal@gmail.com>
|
thanks! |
|
Thank you! For being patient with me. 😃 |
|
No, thank you for your contribution 👍 :) |
No description provided.