New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 revoke endpoint documentation needs improvement #199

Closed

ngrigoriev opened this issue Sep 3, 2019 · 1 comment

Contributor

ngrigoriev commented Sep 3, 2019

I think that the /oauth/revoke endpoint documentation could be improved. I have found that:

if the client is not public, then one MUST use the client ID and secret. It seems the oauth2 authentication mentioned there is an option at all.
if the client is public, then it is an opposite - since there is no password, then basic authentication is not an option. But then it seems that the client MUST send "cliend_id" form field or it will fail

By the way, I have tested all this with JWT token, not the opaque one. Maybe the behavior is even more complex.

Member

aeneasr commented Sep 16, 2019

Oh yeah absolutely - woudl you be up for a PR? :)

aeneasr closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment