Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make amr claim an array to match the OIDC spec #625

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

svrakitin
Copy link
Contributor

@svrakitin svrakitin commented Sep 27, 2021

This change makes amr claim follow the spec and be of an array type.

See: https://openid.net/specs/openid-connect-core-1_0.html#IDToken

My team noticed that when trying to use amr claim with Hydra.

Will follow up with Hydra PR to add support for amr claim as it is being dropped right now if used. Related issue: ory/hydra#1756

Previous change: #401

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

This is breaking change, migration path is to wrap single values into the []string slice and use a different field.

@aeneasr aeneasr merged commit 8a6f66a into ory:master Sep 27, 2021
@svrakitin svrakitin deleted the amr-array branch September 27, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants