Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT access tokens: scope vs scp claim #3524

Closed
3 of 6 tasks
brett-patterson opened this issue May 24, 2023 · 2 comments
Closed
3 of 6 tasks

JWT access tokens: scope vs scp claim #3524

brett-patterson opened this issue May 24, 2023 · 2 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@brett-patterson
Copy link
Contributor

Preflight checklist

Describe your problem

When using the JWT access token strategy, the scopes are encoded in the scp claim as an array of strings. From what I've read (see this RFC), it seems like the more standard way to do this is in the scope claim as a single space-delimited string.

Describe your ideal solution

It does look like the underlying fosite library supports this via the JWTScopeFieldProvider, but Hydra explicitly chooses JWTScopeFieldList. My preferred solution would be a configuration option for Hydra to allow us to opt in to the other scope claim behaviors supported by fosite. This can default to the current scp array strategy for backwards compatibility.

Workarounds or alternatives

It's fairly simple to have any scope checks look at the scp claim, but it makes it harder to use popular libraries like https://www.npmjs.com/package/express-oauth2-jwt-bearer which adhere pretty strictly to the standard scope claim.

Version

2.1.0

Additional Context

No response

@brett-patterson brett-patterson added the feat New feature or request. label May 24, 2023
@aeneasr
Copy link
Member

aeneasr commented May 25, 2023

Makes sense - contributions appreciated!

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants