Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with some data types in values.yaml #475

Closed
3 of 6 tasks
rikkuness opened this issue Jul 29, 2022 · 1 comment · Fixed by #521
Closed
3 of 6 tasks

Issues with some data types in values.yaml #475

rikkuness opened this issue Jul 29, 2022 · 1 comment · Fixed by #521
Labels
bug Something is not working.

Comments

@rikkuness
Copy link

Preflight checklist

Describe the bug

When setting some values such as deployment.extraContainers the documentation and value set in values.yaml suggest the value should be an object here however the example shows a string and given the template here is using {{ tpl .Values.deployment.extraContainers }} I believe the correct value in values.yaml should be "".

There seems to be a few places where this is the case extraContainers, extraInitContainers and lifecycle in the Hydra Helm charts at least.

Reproducing the bug

Set the value of deployment.extraContainers to the example value as per https://github.com/ory/k8s/blob/master/helm/charts/hydra/values.yaml#L318-L320

Relevant log output

coalesce.go:220: warning: cannot overwrite table with non table for example.hydra.deployment.extraContainers (map[])
coalesce.go:220: warning: cannot overwrite table with non table for example.hydra.deployment.extraContainers (map[])
coalesce.go:220: warning: cannot overwrite table with non table for example.hydra.deployment.extraContainers (map[])

Relevant configuration

deployment:
  extraContainers:
    - name: example
      image: example/image

Version

v1.11.7

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes with Helm

Additional Context

No response

@rikkuness rikkuness added the bug Something is not working. label Jul 29, 2022
@Demonsthere
Copy link
Collaborator

Hi there!
The warning are as you noticed, mostly caused by the use of tpl functions which expect strings in places you would expect and object or array. I agree, that the default values.yaml should be updated to reflect that. It was probably missed when we were introducing tpl 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants