fix: tiny stuff #1211
Merged
fix: tiny stuff #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
reviewed
Jan 26, 2023
| @@ -145,7 +145,7 @@ func (t *Traverser) TraverseSubjectSetRewrite(ctx context.Context, start *relati | |||
| } | |||
|
|
|||
| if len(relations) > 0 { | |||
| _, span := t.d.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.TraverseSubjectSetRewrite") | |||
| ctx, span := t.d.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.TraverseSubjectSetRewrite") | |||
There was a problem hiding this comment.
Suggested change
| ctx, span := t.d.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.TraverseSubjectSetRewrite") | |
| var span *otel.Span | |
| ctx, span = t.d.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.TraverseSubjectSetRewrite") |
because of scoping?
There was a problem hiding this comment.
Would not make a difference right now, but might later on. Or maybe just move that to the beginning of the function?
There was a problem hiding this comment.
Actually you're correct! fixed, thx
zepatrik
approved these changes
Jan 26, 2023
hperl
requested changes
Jan 30, 2023
hperl
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.