-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TTL support to relation tuple #346
Comments
I'm wondering if that is something you would be better off by using the ABAC functionality. It could also use the system time as an input. |
I think it can only be integrated to be scalable. Imagine a more deep expand check that may involve more complex tuples herarchies. If we have said, that ABAC is too much to implement into Keto and one should use e.g. OPA on client side: How would you have ACL tuples to expire in a big system? Keto would only use living tuples. I think passing an optional TTL on tuple insertion would be very simple for users. Perhaps TTL would be the only attribute we should support for tuples? 🤔 Otherwise we would need to allow attributes on tuples and allow users to define policy and append context to check/read requests to filter out tuples that not pass at request time (which comes with scalability issues, instead of efficiently query the db just tuples that have sufficient TTL at request time.) |
If we start adding single features like TTL into the core, we will eventually add more and some day end up with OPA (exaggerated). In general we have the following sources of relation tuples:
We can simply add a third one that enables ABAC and all kinds of integration, just by allowing the client to attach tuples to a single request that are only valid and considered for that single request. So in essence TTL could then be implemented similar to:
This changes 0% of the core language but still allows all kinds of fancy rules, ensuring that we can keep the latency low. |
Another approach is to keep the language as simple as possible and have an external service that deleted the ACL at a given time. In other words, the timestamp is not in the ACL. You could for example have scenarios such as: this access on this object is only possible every weekday between 9am and 5pm PST. |
Just curious can it be done now using https://www.ory.sh/docs/keto/reference/ory-permission-language ? |
That would be really appreciated. It would be useful at @NeowayLabs Feature Store Ecossystem |
Hello contributors! I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue
Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic. Unfortunately, burnout has become a topic of concern amongst open-source projects. It can lead to severe personal and health issues as well as opening catastrophic attack vectors. The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone. If this issue was marked as stale erroneously you can exempt it by adding the Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you! Thank you 🙏✌️ |
Is your feature request related to a problem? Please describe.
Allow automatic expiring for ACL tuples. It's a great feature to e.g. allow temporal access to something.
After TTL timestamp expiration the tuple has no longer effects and gets garbage collected.
The text was updated successfully, but these errors were encountered: