Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SQL pagination to not use offset #633

Closed
zepatrik opened this issue Jun 25, 2021 · 3 comments
Closed

Change SQL pagination to not use offset #633

zepatrik opened this issue Jun 25, 2021 · 3 comments
Assignees
Labels
rfc A request for comments to discuss and share ideas. stale Feedback from one or more authors is required to proceed.

Comments

@zepatrik
Copy link
Member

Currently, we use LIMIT ... OFFSET ... pagination. However this is not performant, we should change that to a
WHERE ... SORT ... LIMIT ... pagination. The question rather is how we sort to have a reliable pagination.

  • Sorting by shard_id: as shard IDs are just random, we can't ensure reliable pagination
  • Sorting by commit_time: different distributed nodes might not yet have all updates
  • Sorting by a custom sort field: client is responsible for ensuring reliable pagination, however this is going to be hard and should be optional IMO, so we need a good default fallback strategy

Follow up of #613
Also consider custom sorting: #546

@zepatrik zepatrik added the rfc A request for comments to discuss and share ideas. label Jun 25, 2021
@zepatrik zepatrik self-assigned this Jun 25, 2021
@github-actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan on resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Jun 26, 2022
@zepatrik zepatrik reopened this Jul 27, 2022
@zepatrik zepatrik removed the stale Feedback from one or more authors is required to proceed. label Jul 27, 2022
@zepatrik
Copy link
Member Author

Actually fixed already.

@github-actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc A request for comments to discuss and share ideas. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

1 participant