feat: map strings to UUIDs (#809) #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@zepatrik what about this PR? |
|
This is quite a lot of work. The part done already can't be merged yet 'cause it touches migrations and they might need adjustment. |
hperl
force-pushed
the
feat/uuid-mapping
branch
4 times, most recently
from
208be6a
to
01463b0
Compare
zepatrik
commented
May 12, 2022
contrib/docs-code-samples/list-api-display-objects/99-cleanup/index.js
Outdated
Show resolved
Hide resolved
internal/persistence/sql/migrations/migratest/migration_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
In relation tuples and related API objects such as queries, subjects (including subject sets) and objects are now automatically mapped to and from UUIDs. The mapping is done in each handler and for each protocol (HTTP, gRPC) separately. Below the handler, all objects and subjects are now UUIDs, but still handled as strings, for the following reasons: * No duplication of datastructures (one for type `string`, one for type `uuid.UUID`). * No unnecessary copying, the mapping is done in-place and batched across multiple objects. Additionally, the migration (adding the string values to the mapping table and replacing the values with UUIDs) is now performed automatically as part of the migrations. Tests are in `migratest`, which now also handles `GoMigrations` properly. This method replaces the dedicated command in `cmd/migrate/...` for the UUID mappings.
Sorting the expected output of the docs tests make the tests more robust.
resolves `table locked` errors with sqlite
hperl
approved these changes
May 17, 2022
Database tests now run in separate databases, which opens up the opportunity to run them in parallel.
Database tests now run in separate databases, which opens up the opportunity to run them in parallel.
# Conflicts: # go.mod # go.sum # internal/driver/registry_default.go # internal/persistence/sql/migrations/migratest/migration_test.go # internal/persistence/sql/relationtuples.go # internal/x/dbx/dsn_cockroach.go # internal/x/dbx/dsn_mysql.go # internal/x/dbx/dsn_postgres.go # internal/x/dbx/dsn_sqlite.go # internal/x/dbx/dsn_testutils.go
zepatrik
force-pushed
the
feat/uuid-mapping
branch
from
e2bf8b3
to
2fc02fa
Compare
hperl
reviewed
Jul 12, 2022
hperl
reviewed
Jul 12, 2022
hperl
reviewed
Jul 12, 2022
# Conflicts: # go.sum
# Conflicts: # go.sum # internal/e2e/helpers.go # internal/persistence/sql/full_test.go # internal/persistence/sql/relationtuples.go # internal/relationtuple/manager_requirements.go
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
internal/persistence/sql/migrations/migratest/migration_test.go
Outdated
Show resolved
Hide resolved
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
hperl
reviewed
Jul 19, 2022
hperl
approved these changes
Jul 19, 2022
# Conflicts: # go.mod # go.sum
Namespaces are now only identified by their name, not by their ID. The 'ID' entries in the configuration are still supported, and used for down-migrations when reverting to a schema that still uses the namespace IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #792
Further Comments
Current State:
Next steps:
In the end, we will rebase.