refactor: API paths #862
Merged
refactor: API paths #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the API paths to be consistent with the rest of the Ory ecosystem. This step is required for the unified Ory SDK. Additionally, as we plan to add high level APIs, e.g. for RBAC, the check and expand API paths changed to allow adding those. BREAKING CHANGE: `/check` is now `/acl/check` BREAKING CHANGE: `/expand` is now `/acl/expand` BREAKING CHANGE: `/relation-tuples` is now `/admin/relation-tuples` for write APIs
aeneasr
reviewed
Mar 28, 2022
| @@ -6,5 +6,5 @@ curl -G --silent \ | |||
| --data-urlencode "relation=access" \ | |||
| --data-urlencode "object=/photos/beach.jpg" \ | |||
| --data-urlencode "max-depth=3" \ | |||
| http://127.0.0.1:4466/expand | \ | |||
| http://127.0.0.1:4466/acl/expand | \ | |||
There was a problem hiding this comment.
ACL for Access Control List? Is that the nomenclautur you want to go here?
There was a problem hiding this comment.
I was also not sure about that, but basically yes. The gRPC API is also package ory.keto.acl.v1alpha1, so it would be consistent.
In some way you could say that relation tuples are an ACL?
There was a problem hiding this comment.
Later on we can have /rbac/check and others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the API paths to be consistent with the rest of the Ory ecosystem. This step is required for the unified Ory SDK. Additionally, as we plan to add high level APIs, e.g. for RBAC. The check and expand API paths changed to allow adding those.
BREAKING CHANGES:
/checkis now/relation-tupes/checkBREAKING CHANGES:
/expandis now/relation-tuples/expandBREAKING CHANGES:
/relation-tuplesis now/admin/relation-tuplesfor write APIsBREAKING CHANGES: gRPC package is now called
ory.keto.relation_tuples.v1alpha2BREAKING CHANGES: gRPC relation-tuple-delta action enum names are prefixed with
ACTION_