Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub provider fails with 401 on email when scope is missing #87

Closed
aeneasr opened this issue Aug 23, 2019 · 1 comment
Closed

GitHub provider fails with 401 on email when scope is missing #87

aeneasr opened this issue Aug 23, 2019 · 1 comment
Assignees
Labels
bug Something is not working.

Comments

@aeneasr
Copy link
Member

aeneasr commented Aug 23, 2019

Describe the bug

The GitHub provider fails with a 401 error, the user is redirected to the system error page. Instead,

Reproducing the bug

Most likely configure the github provider without the email scope, then login, then update config, then login again.

@aeneasr aeneasr self-assigned this Aug 23, 2019
@aeneasr aeneasr added the bug Something is not working. label Aug 23, 2019
@aeneasr aeneasr added this to the v0.0.1 milestone Aug 23, 2019
@aeneasr aeneasr modified the milestones: v0.2.0-alpha.1, v0.2.1-alpha.1 May 2, 2020
@aeneasr
Copy link
Member Author

aeneasr commented May 6, 2020

This has been fixed with the introduction of Jsonnet because the behavior is now modifiable in the Jsonnet file (e.g. raise error which would cause this behavior, set a default, ask the user to set the value, ...)

@aeneasr aeneasr closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant