Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing identitypassword field from ClientSelfServiceLoginFlow #158

Open
4 of 6 tasks
roboptics opened this issue Mar 11, 2022 · 6 comments
Open
4 of 6 tasks

Missing identitypassword field from ClientSelfServiceLoginFlow #158

roboptics opened this issue Mar 11, 2022 · 6 comments
Labels
bug Something is not working.

Comments

@roboptics
Copy link

roboptics commented Mar 11, 2022

Preflight checklist

Describe the bug

The "password_identifier" ui node shifted from the "password" group to the "default" group and is now called "identifier".
No changes were made to our identity schema.

From the documentation:
Customize User Interface

The "default" group is cleary identified as a placeholder for the CSRF token, so this change seems to be a bug. As a consequence, we now have the username and the password / submit button in different group boxes...

Please advise.

Reproducing the bug

Browse the login ui.

Relevant log output

No response

Relevant configuration

No response

Version

0.0.1-alpha.76

On which operating system are you observing this issue?

Windows

In which environment are you deploying?

Docker Compose

Additional Context

No response

@roboptics roboptics added the bug Something is not working. label Mar 11, 2022
@aeneasr
Copy link
Member

aeneasr commented Mar 15, 2022

This change is not yet released officially, you are probably running off of master?

@roboptics
Copy link
Author

Hi,

We're actually using Ory Cloud, so I don't think this is on our side... can you please check?

@aeneasr
Copy link
Member

aeneasr commented Mar 18, 2022

Sorry, I missed this, can you please update your SDK to e.g. 0.0.1-alpha.131? Please don't use >= 132 yet as those changes are currently in the pipeline to be released.

@roboptics
Copy link
Author

Hi,

Updated to 0.0.1-alpha.131 and now the ClientSubmitSelfServiceLoginFlowWithPasswordMethodBody (model) class constructor has an addittional argument to pass the identifier value (previously we were sending it in the identifierPassword argument when it was null). Non the less, the identifier is still on the default group, which causes the final UI layout to look strange, since the identifier and the password appear on two separated groups (e.g. group box).

Will the identifier be moved to the password group or is this change intended?

Best,

@aeneasr
Copy link
Member

aeneasr commented Mar 18, 2022

Thank you for the question, this change is one of the breaking changes we had to introduce for custom UIs, in order to support passwordless methods (magic link, sms, webauthn) in the future. So yes, this change is intended because the identifier (e.g. the email) might be used for several "login" methods:

  • login with email magic link
  • login with email + yubikey
  • login with email + password
  • ...

@aeneasr
Copy link
Member

aeneasr commented Mar 18, 2022

But you can of course order this in your custom UI so that it fits your needs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants