-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing identitypassword field from ClientSelfServiceLoginFlow #158
Comments
This change is not yet released officially, you are probably running off of master? |
Hi, We're actually using Ory Cloud, so I don't think this is on our side... can you please check? |
Sorry, I missed this, can you please update your SDK to e.g. 0.0.1-alpha.131? Please don't use >= 132 yet as those changes are currently in the pipeline to be released. |
Hi, Updated to 0.0.1-alpha.131 and now the ClientSubmitSelfServiceLoginFlowWithPasswordMethodBody (model) class constructor has an addittional argument to pass the identifier value (previously we were sending it in the identifierPassword argument when it was null). Non the less, the identifier is still on the default group, which causes the final UI layout to look strange, since the identifier and the password appear on two separated groups (e.g. group box). Will the identifier be moved to the password group or is this change intended? Best, |
Thank you for the question, this change is one of the breaking changes we had to introduce for custom UIs, in order to support passwordless methods (magic link, sms, webauthn) in the future. So yes, this change is intended because the identifier (e.g. the email) might be used for several "login" methods:
|
But you can of course order this in your custom UI so that it fits your needs :) |
Preflight checklist
Describe the bug
The "password_identifier" ui node shifted from the "password" group to the "default" group and is now called "identifier".
No changes were made to our identity schema.
From the documentation:
Customize User Interface
The "default" group is cleary identified as a placeholder for the CSRF token, so this change seems to be a bug. As a consequence, we now have the username and the password / submit button in different group boxes...
Please advise.
Reproducing the bug
Browse the login ui.
Relevant log output
No response
Relevant configuration
No response
Version
0.0.1-alpha.76
On which operating system are you observing this issue?
Windows
In which environment are you deploying?
Docker Compose
Additional Context
No response
The text was updated successfully, but these errors were encountered: