Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revokeOAuth2LoginSessions client API to include the sid parameter #259

Closed
4 of 6 tasks
kabirbaidhya opened this issue Mar 21, 2023 · 2 comments
Closed
4 of 6 tasks
Labels
feat New feature or request.

Comments

@kabirbaidhya
Copy link

Preflight checklist

Describe your problem

With ory/hydra#3450 merged, the revokeOAuth2LoginSessions API now supports revoking login sessions by sid but I can see that it's not reflected in the client SDK yet.

It still only accepts subject and not sid.
https://github.com/ory/sdk/blob/master/clients/client/typescript/api.ts#L14908-L14911

When are you planning to release this change in ory/hydra and @ory/hydra-client package?

Describe your ideal solution

Update the Client SDK to reflect the recent updates on ory/hydra so that it's reflected in @ory/hydra-client.

Workarounds or alternatives

N/A

Version

v2.0.2

Additional Context

No response

@kabirbaidhya kabirbaidhya added the feat New feature or request. label Mar 21, 2023
@jonas-jonas
Copy link
Member

Thanks for the question. ory/client is kept in sync with what is running in the Ory Network. Hydra was not yet updated there, hence why the parameter is not available in the SDK yet.

If you're self-hosting, the SDK will be updated with the next Hydra update. That should be right around the corner. If that's not early enough, you can also build the SDK yourself from the Open API schema in ory/hydra.

@jonas-jonas
Copy link
Member

We are in the process of updating Hydra in the Ory Network now, but I just realized, that you were talking about a self-hosted Hydra instance with the standalone SDK, which now includes the updates, since last week. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants