Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Ory-Kratos-Client is outdated #323

Closed
4 of 5 tasks
Jeremiah-Griffin opened this issue Feb 8, 2024 · 4 comments
Closed
4 of 5 tasks

Rust Ory-Kratos-Client is outdated #323

Jeremiah-Griffin opened this issue Feb 8, 2024 · 4 comments
Labels
bug Something is not working.

Comments

@Jeremiah-Griffin
Copy link

Jeremiah-Griffin commented Feb 8, 2024

Preflight checklist

Ory Network Project

No response

Describe the bug

I can't remember why I needed to use it, but this repo and the version on crates io are a few months out of date. I'm now using the ory-client package now so this is not a blocker for me at the moment.

For example IdentityCredentialsType is missing the "Code", "LinkRecovery", and "CodeRecovery" variants of TypeEnum which replaced it. This can cause a runtime Serde error when calling the create_identity admin api and one of those variants is returned.

Reproducing the bug

Observe that the API version of ory-kratos-client is 1.0.0. Observe that the API version of ory-client is 1.6.1.

Relevant log output

No response

Relevant configuration

No response

Version

1.0.0

On which operating system are you observing this issue?

Ory Network

In which environment are you deploying?

Ory Network

Additional Context

No response

@Jeremiah-Griffin Jeremiah-Griffin added the bug Something is not working. label Feb 8, 2024
@sjud
Copy link

sjud commented Feb 27, 2024

The ory-kratos-client was rebuilt last week, but I wanted to document some inconsistencies here

LoginFlow
https://docs.rs/ory-kratos-client/latest/ory_kratos_client/models/login_flow/struct.LoginFlow.html
field ui : UiContainer
https://docs.rs/ory-kratos-client/latest/ory_kratos_client/models/ui_container/struct.UiContainer.html
has a vec of type UiNode
https://docs.rs/ory-kratos-client/latest/ory_kratos_client/models/ui_node/struct.UiNode.html
which has an UiNodeAttributes enum
https://docs.rs/ory-kratos-client/latest/ory_kratos_client/models/ui_node_attributes/enum.UiNodeAttributes.html

This enum doesn't have node_type in it's fields so it can't serialize the response from
https://www.ory.sh/docs/reference/api#tag/frontend/operation/getLoginFlow
which expects node_type
Alternatively there were 5 specific models generated, which were not part of an enum.
All of which have node_type. For instance, the input ui node.
https://docs.rs/ory-kratos-client/latest/ory_kratos_client/models/ui_node_input_attributes/struct.UiNodeInputAttributes.html#structfield.node_type
Unfortunately AFAIK those types are not actually used anywhere.

@Jeremiah-Griffin
Copy link
Author

This issue is known and has been around for quite some time. It is blocked on an upstream fix.

#325 (comment).

Leaving this issue open as the client is still months behind the current version

@sjud
Copy link

sjud commented Feb 28, 2024

This issue is known and has been around for quite some time. It is blocked on an upstream fix.

#325 (comment).

Leaving this issue open as the client is still months behind the current version

Thanks, yes the node_type change ended up being the solution. I missed that issue thanks for linking it. :)

@aeneasr
Copy link
Member

aeneasr commented Jul 8, 2024

The pipeline is now fixed and the pipeline will properly propagate with the next release.

@aeneasr aeneasr closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

3 participants