Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.1 is completely different from 1.9.0, what is the semver rule here? #54

Closed
ericdevries opened this issue Jan 27, 2021 · 3 comments
Closed

Comments

@ericdevries
Copy link

I just updated from 1.9.0 to 1.9.1 and the python interface changed completely. A minor version update should not introduce any API changes. What was the reasoning behind this?

@aeneasr
Copy link
Member

aeneasr commented Jan 27, 2021

Hm, I think that is a sideeffect of the new dart and rust SDKs. I think we upgraded to the latest version of openapi-generator which, apparently, has breaking changes for the python client code. We currently don't have a process to ensure that the generated code stays the same for all languages. Sorry about that!

If you want, you can generate the client yourself - or downgrade back to 1.9.0 as there aren't any functional changes. Or, you can use the old openapi generator CLI to generate the client yourself.

@ericdevries
Copy link
Author

The changes were minor, but luckily I was still actively developing it, otherwise it might have seriously impacted our business.

@aeneasr
Copy link
Member

aeneasr commented Jan 31, 2021

Given that there were no breaking API changes on the HTTP side, you can just keep using the old SDK - so there would have been no impact as everything would continue running smoothly :) Anyways, glad you got it resolved!

@aeneasr aeneasr closed this as completed Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants