Prevent tags from getting cut by long build numbers #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolo
reviewed
May 11, 2017
assets/stylesheets/openqa.scss
Outdated
| } | ||
|
|
||
| .col-lg-4.text-nowrap span { | ||
| font-size: 17px; |
There was a problem hiding this comment.
if this is to align with the font size of h4, better use $font-size-h4 - that's the reason we use sass
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
- Coverage 87.15% 71.65% -15.5%
==========================================
Files 104 95 -9
Lines 7363 6968 -395
==========================================
- Hits 6417 4993 -1424
- Misses 946 1975 +1029
Continue to review full report at Codecov.
|
|
Fixed font-size part @coolo |
|
Had to import the theme_variables.scss file to the openqa.scss. Hope that is the right way. @coolo |
|
please write commit message subject lines without the |
krauselukas
changed the title
Related progress issue: https://progress.opensuse.org/issues/12942
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://progress.opensuse.org/issues/12942
Already fixed the issue with those long build numbers by shorten them with dots. But then the tags got cut aswell. Now the tags are always visible and just the text and timeago part gets shortend.