Disable printing time when logging to STDERR. #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
force-pushed
the
logging_stderr
branch
2 times, most recently
from
a47ff9a
to
bd8d934
Compare
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 86.84% 86.86% +0.01%
==========================================
Files 101 101
Lines 7427 7436 +9
==========================================
+ Hits 6450 6459 +9
Misses 977 977
Continue to review full report at Codecov.
|
mudler
force-pushed
the
logging_stderr
branch
11 times, most recently
from
cd55fe0
to
005e648
Compare
mudler
changed the title
mudler
changed the title
If a file for logging is supplied then set the logger format to print also the time, otherwise don't. Related Progress issue: https://progress.opensuse.org/issues/13866
Refactor config testing adding more test cases and avoiding also to overwrite configuration file shipped in the sources.
mudler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file for log is supplied, then format the logger to print also the time, otherwise don't.
Related Progress issue: Poo#13866
WIP until i figure out why unit test is failing on travis (but succeds locally)Added tests cases as well to cover why CI was failing