Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduler being always busy #1876

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Fix scheduler being always busy #1876

merged 3 commits into from
Nov 21, 2018

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Nov 20, 2018 •
edited
Loading

... after summoned by the web UI with no free workers left. See https://progress.opensuse.org/issues/43991

I also did a few other adjustments (see particular commit messages).

@Martchus
Fix comment in scheduler code
d1c4079 
The default for SCHEDULE_TICK_MS is actually 20 seconds.
@Martchus
Remove unused variable $force in _reschedule()
98b471a
@Martchus
Call _reschedule after schedule concluded
b28e047 
That was mostly the case before, but not for the early return
in case no worker is available. That lead to the tick being
stuck at 1 ms keeping the scheduler always busy.

See https://progress.opensuse.org/issues/43991
@Martchus Martchus requested a review from mudler November 20, 2018 15:58
mudler
mudler approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, this seems an oversight during the refactoring of filter_jobs. The failure are unrelated to the changes

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #1876 into master will decrease coverage by 0.07%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
- Coverage    90.5%   90.43%   -0.08%     
==========================================
  Files         148      148              
  Lines       10248    10348     +100     
==========================================
+ Hits         9275     9358      +83     
- Misses        973      990      +17
Impacted Files Coverage Δ
lib/OpenQA/Scheduler.pm 100% <ø> (ø) ⬆️
lib/OpenQA/Scheduler/Scheduler.pm 86.75% <90%> (+0.45%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/JobGroup.pm 88.34% <0%> (-9.33%) ⬇️
lib/OpenQA.pm 69.23% <0%> (-2.57%) ⬇️
lib/OpenQA/WebSockets/Server.pm 92.2% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84eba94...b28e047. Read the comment docs.

@Martchus Martchus merged commit 7be0d19 into os-autoinst:master Nov 21, 2018
@Martchus Martchus deleted the fix_scheduler branch November 21, 2018 10:25
coolo pushed a commit that referenced this pull request Nov 21, 2018
Update documentation to commit 7be0d19
43b3553 
commit 7be0d19
Merge: bd872c4 b28e047
Author:     Martchus <martchus@gmx.net>
AuthorDate: Wed Nov 21 11:25:28 2018 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Nov 21 11:25:28 2018 +0100

    Merge pull request #1876 from Martchus/fix_scheduler

    Fix scheduler being always busy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martchus @mudler