Fix various uses of the is_admin helper in templates

[kraih]

The is_admin helper returns a Perl boolean, but was used to generate JavaScript booleans directly here. There was one more use of <%= is_admin %> for setupJobTemplates, but that function does not actually use that argument at all, so i opted to remove it.

While the fix was very simple, i'm still trying to find a good place to test this and am learning Selenium in the process. So please consider this pull request a work in progress for now.

Progress issue: https://progress.opensuse.org/issues/44039

[Martchus]

Changed the title since you're saying it is still WIP. But it looks already good. (Beside the fact that the admin table code isn't a very nice place.)

[coolo]

as you put the same code now in 3 places, this sounds like a good helper candidate

[kraih]

Sure, do you have a preferred naming convention for js generating helpers?

[kraih]

Otherwise i suppose is_admin_js or js_is_admin would work. Not sure which i prefer.

[kraih]

Ok, this should be ready now. I've added a new helper and test.

[Martchus]

I re-triggered the failing test because it looks unrelated. If I remember correctly, I have already seen this failure before.

#   Failed test 'No tests run for subtest "Test Minion task registration and execution"'
#   at ./t/25-cache-service.t line 447.
<7>[1374] [d] Process 1481 is performing job "36" with task "cache_asset"
Can't call method "execute" on an undefined value at ./t/25-cache-service.t
	line 442 (#1)
    (F) You used the syntax of a method call, but the slot filled by the
    object reference or package name contains an undefined value.  Something
    like this will reproduce the error:

        $BADREF = undef;
        process $BADREF 1,2,3;
        $BADREF->process(1,2,3);

Uncaught exception from user code:
	Can't call method "execute" on an undefined value at ./t/25-cache-service.t line 442.
	Test::Builder::subtest('Test::Builder=HASH(0x5930ff0)', 'Test Minion task registration and execution', 'CODE(0xcb8f0e8)') called at /usr/lib/perl5/vendor_perl/5.18.2/Test/More.pm line 807
	Test::More::subtest('Test Minion task registration and execution', 'CODE(0xcb8f0e8)') called at ./t/25-cache-service.t line 447

[kraih]

Yea, that test failure can't be related to this pull request.

[codecov]

Codecov Report

Merging #1879 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
+ Coverage   90.56%   90.68%   +0.11%     
==========================================
  Files         148      148              
  Lines       10250    10249       -1     
==========================================
+ Hits         9283     9294      +11     
+ Misses        967      955      -12

Impacted Files	Coverage Δ
lib/OpenQA/WebAPI/Plugin/Helpers.pm	93.98% <100%> (-0.04%)	⬇️
lib/OpenQA/Worker/Engines/isotovideo.pm	96.59% <0%> (-0.57%)	⬇️
lib/OpenQA/WebAPI/Controller/Test.pm	96.14% <0%> (+0.02%)	⬆️
lib/OpenQA/Utils.pm	92.08% <0%> (+0.22%)	⬆️
lib/OpenQA/WebAPI/Controller/Step.pm	84.59% <0%> (+0.36%)	⬆️
lib/OpenQA/WebSockets/Server.pm	92.2% <0%> (+0.45%)	⬆️
lib/OpenQA/Worker/Common.pm	83.33% <0%> (+2.17%)	⬆️
lib/OpenQA.pm	71.79% <0%> (+2.56%)	⬆️
lib/OpenQA/Worker/Commands.pm	88.46% <0%> (+2.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be0d19...e6197a5. Read the comment docs.