Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation about test flags (especially fatal) #2624

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Improve documentation about test flags (especially fatal) #2624

merged 1 commit into from
Jan 1, 2020

Conversation

Martchus
Copy link
Contributor

okurz
okurz approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm neutral regarding the change to move the flag comments out of the example code, everything else is an improvement.

@codecov
Copy link

codecov bot commented Dec 19, 2019 •
edited
Loading

Codecov Report

Merging #2624 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2624      +/-   ##
==========================================
+ Coverage   91.71%   91.86%   +0.14%     
==========================================
  Files         183      183              
  Lines       11420    11420              
==========================================
+ Hits        10474    10491      +17     
+ Misses        946      929      -17
Impacted Files Coverage Δ
lib/OpenQA/Schema/Result/Jobs.pm 94.7% <0%> (+0.23%) ⬆️
lib/OpenQA/WebAPI/Controller/Test.pm 96.93% <0%> (+0.61%) ⬆️
lib/OpenQA/WebAPI.pm 97.24% <0%> (+0.68%) ⬆️
lib/OpenQA/Schema/ResultSet/Jobs.pm 96.61% <0%> (+1.69%) ⬆️
lib/OpenQA/Scheduler/Model/Jobs.pm 91.09% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfa2ed...712f2db. Read the comment docs.

@okurz okurz merged commit 68ae00a into os-autoinst:master Jan 1, 2020
@Martchus Martchus deleted the fatal-doc branch January 1, 2020 14:53
openqabot pushed a commit to openqabot/openQA that referenced this pull request Jan 2, 2020
Update documentation to commit 68ae00a
48fc4f9 
commit 68ae00a
Merge: e01a0c0 712f2db
Author:     Oliver Kurz <okurz@suse.de>
AuthorDate: Wed Jan 1 12:53:27 2020 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Jan 1 12:53:27 2020 +0100

    Merge pull request os-autoinst#2624 from Martchus/fatal-doc

    Improve documentation about test flags (especially fatal)
openqabot pushed a commit to openqabot/openQA that referenced this pull request Jan 3, 2020
Update documentation to commit 68ae00a
db3a493 
commit 68ae00a
Merge: e01a0c0 712f2db
Author:     Oliver Kurz <okurz@suse.de>
AuthorDate: Wed Jan 1 12:53:27 2020 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Jan 1 12:53:27 2020 +0100

    Merge pull request os-autoinst#2624 from Martchus/fatal-doc

    Improve documentation about test flags (especially fatal)
openqabot pushed a commit to openqabot/openQA that referenced this pull request Jan 4, 2020
Update documentation to commit 68ae00a
ffb1fb4 
commit 68ae00a
Merge: e01a0c0 712f2db
Author:     Oliver Kurz <okurz@suse.de>
AuthorDate: Wed Jan 1 12:53:27 2020 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Jan 1 12:53:27 2020 +0100

    Merge pull request os-autoinst#2624 from Martchus/fatal-doc

    Improve documentation about test flags (especially fatal)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martchus @okurz