t: Use explicit wait functions where needed #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
commented
Mar 2, 2020
okurz
force-pushed
the
enhance/unstables
branch
2 times, most recently
from
e340402
to
eb0365f
Compare
When the command within "run_once" fails we must not only break the loop but also preserve the exit code. This was observed when trying out STABILITY_TEST in more cases which is not affecting our current circle CI based tests as they do not use STABILITY_TEST anywhere in the current state.
To not rely on a global Selenium timeout in test functions we should use our explicit wait functions where they are needed.
Codecov Report
@@ Coverage Diff @@
## master #2765 +/- ##
==========================================
+ Coverage 92.11% 92.13% +0.01%
==========================================
Files 190 190
Lines 11840 11840
==========================================
+ Hits 10907 10909 +2
+ Misses 933 931 -2
Continue to review full report at Codecov.
|
|
I consider this also pair-reviewed with mkittler and mergeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not rely on a global Selenium timeout in test functions we should use
our explicit wait functions where they are needed.