Migrate templates #282
Merged
Migrate templates #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolo
force-pushed
the
migrate_templates
branch
from
23dc14f
to
ac83a32
Compare
| } | ||
| } | ||
| } | ||
| unless (defined($entry->{group_name})) { |
There was a problem hiding this comment.
I was thinking, when JobGroups::name is 'is_nullable' 0, there should be unless ($entry->{group_name}). Since you are validating text user input so '' should be considered invalid.
There was a problem hiding this comment.
Yeah, technically DBIx takes only undef as null, so defined check is enough. So is '' supposed to be valid group name?
There was a problem hiding this comment.
this is about migrating the templates within the script. If we add some validation for the group name it should be in the API - validating here doesn't make sense
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.