Improve the operation of 'jobs post' #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
==========================================
+ Coverage 93.23% 93.23% +<.01%
==========================================
Files 189 189
Lines 11880 11888 +8
==========================================
+ Hits 11076 11084 +8
Misses 804 804
Continue to review full report at Codecov.
|
okurz
requested changes
Mar 24, 2020
kalikiana
requested changes
Mar 24, 2020
okurz
reviewed
Mar 25, 2020
okurz
approved these changes
Mar 25, 2020
kalikiana
requested changes
Mar 25, 2020
In the current code, the settings start with `+` will be added to the
job when creating a job using `jobs post` as `{+key => value}`.
Following the rule that defined in `isos post` to handle this.
See: https://progress.opensuse.org/issues/63565
kalikiana
approved these changes
Mar 26, 2020
|
looks better and better :) |
|
Reverting due to https://progress.opensuse.org/issues/64938 |
|
Considering #2877 (comment) you can likely re-create that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, the settings start with
+will be added to the job when creating a job usingjobs postas{+key => value}.Handle this by following the rule that defined in
schedule_isoWhen we cloning a job, the settings that removed by clone script are added into the job's settings again if the settings are defined in TestSuite or Product or Machine. Because the create job function re-generate the settings.
See: https://progress.opensuse.org/issues/63883
https://progress.opensuse.org/issues/63565