-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the operation of 'jobs post' #2861
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
==========================================
+ Coverage 93.23% 93.23% +<.01%
==========================================
Files 189 189
Lines 11880 11888 +8
==========================================
+ Hits 11076 11084 +8
Misses 804 804
Continue to review full report at Codecov.
|
In the current code, the settings start with `+` will be added to the job when creating a job using `jobs post` as `{+key => value}`. Following the rule that defined in `isos post` to handle this. See: https://progress.opensuse.org/issues/63565
looks better and better :) |
Reverting due to https://progress.opensuse.org/issues/64938 |
Considering #2877 (comment) you can likely re-create that PR. |
In the current code, the settings start with
+
will be added to the job when creating a job usingjobs post
as{+key => value}
.Handle this by following the rule that defined in
schedule_iso
When we cloning a job, the settings that removed by clone script are added into the job's settings again if the settings are defined in TestSuite or Product or Machine. Because the create job function re-generate the settings.
See: https://progress.opensuse.org/issues/63883
https://progress.opensuse.org/issues/63565