Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summarize results in test details tab (alternative) #3222

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Summarize results in test details tab (alternative) #3222

merged 2 commits into from
Jul 1, 2020

Conversation

ilausuch
Copy link
Contributor

@ilausuch ilausuch commented Jun 30, 2020 •
edited
Loading

https://progress.opensuse.org/issues/44654

This helps to get a quick overview in test details showing grouped results in tab on details page.

image

unlike in #3184 this approach used the backend to render the summary

@ilausuch ilausuch mentioned this pull request Jun 30, 2020
Closed
@ilausuch
Copy link
Contributor Author

This is not complete, I think it requires update some code in the refreshInfoPanel

Martchus
Martchus requested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the other comments, I also think that "stars" is generally a very unspecific name. These figures are already called "job module statistics" or similar in other places. So at least for being consistent it would be nice to stick to that name.

lib/OpenQA/WebAPI/Controller/Test.pm Outdated Show resolved Hide resolved
templates/webapi/test/infopanel.html.ep Outdated Show resolved Hide resolved
@ilausuch ilausuch force-pushed the sumarize_results_in_tab_2 branch 2 times, most recently from 6657c58 to dd0527c Compare June 30, 2020 13:37
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited
Loading

Codecov Report

Merging #3222 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3222      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.02%     
==========================================
  Files         211      211              
  Lines       12930    12933       +3     
==========================================
+ Hits        11895    11896       +1     
- Misses       1035     1037       +2
Impacted Files Coverage Δ
lib/OpenQA/Worker/Job.pm 75.55% <100.00%> (+0.11%) ⬆️
lib/OpenQA/WebAPI/Controller/Test.pm 96.56% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 560f446...bfa192a. Read the comment docs.

@ilausuch ilausuch marked this pull request as ready for review June 30, 2020 14:25
@ilausuch
Copy link
Contributor Author

ilausuch commented Jul 1, 2020

Fixed and squashed in two commits

@kalikiana kalikiana changed the title Sumarize results in tab 2 Summarize results in test details tab (alternative) Jul 1, 2020
kalikiana
kalikiana approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and elegant now. Thanks for working on this!

kraih
kraih approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@kraih kraih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

Martchus
Martchus requested changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now redundant code (Perl implementation + JavaScript implementation). If that's the way to go I'm fine with it. However, it would be nice to add comments to each implementation stating that the other place possibly needs to be updated as well.

Automatic tests are missing. It is not that important for a feature like this but some basic test would likely easy to implement.

templates/webapi/test/infopanel.html.ep Outdated Show resolved Hide resolved
assets/javascripts/tests.js Outdated Show resolved Hide resolved
@ilausuch
Extract renderTestSummary as a common helper to print the job summary
a48572c 
To help future uses, the code to paint the summary of a job has been
extracted to a common helper.
@ilausuch
Add a job summary into the detail page
bfa192a 
https://progress.opensuse.org/issues/44654

This helps to get a quick overview in test details
showing grouped results in tab on details page.
@ilausuch
Copy link
Contributor Author

ilausuch commented Jul 1, 2020

@Martchus Done

@mergify mergify bot merged commit 4711b8d into os-autoinst:master Jul 1, 2020
@ilausuch ilausuch deleted the sumarize_results_in_tab_2 branch November 5, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih approved these changes

@kalikiana kalikiana kalikiana approved these changes

@Martchus Martchus Martchus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilausuch @kraih @kalikiana @Martchus