Enable eslint:recommended rules related to syntax and logic errors #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
approved these changes
Jul 29, 2021
okurz
reviewed
Jul 29, 2021
perlpunk
approved these changes
Jul 29, 2021
openqabot
pushed a commit
to openqabot/openQA
that referenced
this pull request
Jul 30, 2021
commit a8705a8 Merge: 9faa78e cb3c481 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Thu Jul 29 17:49:46 2021 +0000 Commit: GitHub <noreply@github.com> CommitDate: Thu Jul 29 17:49:46 2021 +0000 Merge pull request os-autoinst#4088 from os-autoinst/k/eslint_errors Enable eslint:recommended rules related to syntax and logic errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first followup to #4042. It enables all rules from the
eslint:recommendedset that are related to syntax and logic errors. We had quite a few violations of the no-prototype-builtins rule for example.Progress: https://progress.opensuse.org/issues/91638